Skip to content

feat(TFP): Upgrade TFP linter to golangci-lint v2#1277

Open
Manuelvaas wants to merge 6 commits intomainfrom
feature/upgrade-to-golangci-lint-v2
Open

feat(TFP): Upgrade TFP linter to golangci-lint v2#1277
Manuelvaas wants to merge 6 commits intomainfrom
feature/upgrade-to-golangci-lint-v2

Conversation

@Manuelvaas
Copy link
Copy Markdown

@Manuelvaas Manuelvaas commented Mar 5, 2026 •
edited
Loading

Description

relates to STACKITTPR-253

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@Manuelvaas Manuelvaas force-pushed the feature/upgrade-to-golangci-lint-v2 branch from b50a03c to 93aaab5 Compare March 9, 2026 09:34
@Manuelvaas Manuelvaas marked this pull request as ready for review March 9, 2026 09:41
@Manuelvaas Manuelvaas requested a review from a team as a code owner March 9, 2026 09:41
@Manuelvaas Manuelvaas force-pushed the feature/upgrade-to-golangci-lint-v2 branch from 93aaab5 to e9aca10 Compare March 9, 2026 09:42
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 9, 2026

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit 1.29% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/access_token 21.43% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/cdn/distribution 46.72% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/dns 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/image 37.43% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/logme/credential 11.45% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/logs 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/mariadb/credential 16.29% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/objectstorage/credential 22.59% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/opensearch/credential 16.48% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/postgresflex/database 12.08% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/rabbitmq/credential 23.65% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/redis/credential 16.29% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/scf 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/serverbackup/schedule 14.37% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/resourcepool 19.14% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/share 11.27% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/cluster 49.06% (-0.11%) 👎
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/cdn/distribution/resource.go 42.99% (ø) 421 181 240
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/image/resource.go 32.01% (ø) 278 89 189
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/logme/credential/datasource.go 0.00% (ø) 39 0 39
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/logme/credential/resource.go 14.96% (ø) 127 19 108
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/mariadb/credential/datasource.go 0.00% (ø) 39 0 39
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/mariadb/credential/resource.go 20.86% (ø) 139 29 110
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/objectstorage/credential/datasource.go 24.00% (ø) 75 18 57
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/objectstorage/credential/resource.go 22.12% (ø) 226 50 176
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/opensearch/credential/datasource.go 0.00% (ø) 39 0 39
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/opensearch/credential/resource.go 21.17% (ø) 137 29 108
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/postgresflex/database/resource.go 15.15% (ø) 165 25 140
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/rabbitmq/credential/datasource.go 0.00% (ø) 39 0 39
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/rabbitmq/credential/resource.go 29.27% (ø) 164 48 116
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/redis/credential/datasource.go 0.00% (ø) 39 0 39
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/redis/credential/resource.go 20.86% (ø) 139 29 110
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/serverbackup/schedule/resource.go 13.94% (ø) 251 35 216
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/resourcepool/resource.go 15.28% (ø) 229 35 194
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/share/resource.go 8.26% (ø) 218 18 200
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/cluster/resource.go 51.27% (-0.11%) 864 (-2) 443 (-2) 421 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/provider.go 1.29% (ø) 155 2 153

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/access_token/ephemeral_resource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/dns/dns_acc_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/iaas_acc_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/logs/logs_acc_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/scf/scf_acc_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/ske_acc_test.go

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 17, 2026

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions bot added the Stale PR is marked as stale due to inactivity. label Mar 17, 2026
@Fyusel Fyusel removed the Stale PR is marked as stale due to inactivity. label Mar 17, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 25, 2026

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions bot added the Stale PR is marked as stale due to inactivity. label Mar 25, 2026
@rubenhoenle rubenhoenle removed the Stale PR is marked as stale due to inactivity. label Mar 27, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions bot added the Stale PR is marked as stale due to inactivity. label Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Stale PR is marked as stale due to inactivity.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Manuelvaas @Fyusel @rubenhoenle